hyperref error using latex: "Illegal parameter number in definition of \Hy@temp" [closed]

Question

I have a new laptop and installed Ubuntu 14.04 including TeX Live. A LaTeX file which worked well under Ubuntu 12.04 now gives error "Illegal parameter number in definition of \Hy@temp" when calling latex at every \citeads command (but not for pdflatex). The file is example.tex at http://www.staff.science.uu.nl/~rutte101/Report_recipe.html and is a decades-old latex primer, more recently expanded with bibtex cite macros that turn in-text citations into web browser openers for the astronomy literature database at NASA. These macros were contributed and are recommended by the journal Astronomy & Astrophysics. The errors are non-fatal (answering with "s" produces the proper example.dvi result).

Has something changed in hyperref? Is there a mistake in the citeads macros in that file?

MWE:

\documentclass{article}
\usepackage{natbib}
\usepackage{twoopt}
\usepackage{hyperref}

\makeatletter
\newcommandtwoopt{\citetads}[3][][]{%
  \href{http://adsabs.harvard.edu/abs/#3}{%
    \def\hyper@linkstart##1##2{}%
    \let\hyper@linkend\@empty%
    \citet[#1][#2]{#3}%
  }
}
\makeatother

\begin{document}
  \citetads{1981ApJ...247L..97M}
\end{document}

February 27 2019: solved by linuxss privately with

\makeatletter
\protected\def\sppresslink{\def\hyper@linkstart##1##2{}\let\hyper@linkend\@empty}
 \newcommandtwoopt{\citeads}[3][][]{
   \href{http://adsabs.harvard.edu/abs/#3}
        {\sppresslink \citealp[#1][#2]{#3}}}
\makeatother

Answer 1

The following fix inserting \nonstopmode and \errorstopmode works by having latex not stop at an error within \citeads, but this will make latex also not stop at a serious error in a citation. I would rather have a recoding of the macro in the above MWE to not get the "Illegal parameter number in definition of \Hy@temp." warning. So help is still welcome!

(apology: I don't know how to format the following properly; the stackexchange entry window undoes the newlines and spacings, so I added a newline per line)

\makeatletter
 \newcommandtwoopt{\citetads}[3][][]{%
  \nonstopmode%
  \href{http://adsabs.harvard.edu/abs/#3}{\def\hyper@linkstart##1##2{}%
    \let\hyper@linkend\@empty\citet[#1][#2]{#3}}%
  \errorstopmode}
\makeatother

Answer 2

When I compiled your MWE, I get the following result as output (Windows Machine with TeXLive 2013 installed from iso image):

Now, I feel there is problem with the installation of TeXLive. If you have installed it from the terminal, then make sure is the command sudo apt-get install texlive-full rather than simply sudo apt-get install texlive or sudo apt-get install texlive-base. Second, If it is from the iso, then the only way I feel should be updation. Try to update all the packages (if you can)(the command is tlmgr update all) else the packages natbib, twoopt and hyperref. This should solve the problem. The commands are :
tlmgr update self (requires sometimes. Better if it is done i.e Updating the TeXLive Manager before updating the packages). Then tlmgr update --package name--. That should do it.