One `\newcommand` for inserting figures differentiating two cases with/without captions

Question

I have written the following two \newcommand for inserting figures with or without a caption, respectively.

% for fig with caption: #1: width/size; #2: fig file; #3: fig caption
\newcommand{\figwithcaption}[3]{
  \begin{figure}[htp]
    \centering
      \includegraphics[#1]{#2}
      \caption{#3}
  \end{figure}
}

% for fig without caption: #1: width/size; #2: fig file
\newcommand{\fignocaption}[2]{
  \begin{figure}[htp]
    \centering
    \includegraphics[#1]{#2}
  \end{figure}
}

How to unify them into one \newcommand called, say, \fig which differentiates the two cases above according to the actual number of arguments it receives?

\fig{width = 0.50\textwidth}{fig/duck.pdf} % for fig without caption
\fig{width = 0.50\textwidth}{fig/duck.pdf}{A duck.} % for fig with caption

Answer 1

Really I wouldn't use a command at all, it is better to use the enviornment syntax (for example it helps editors to syntax highlight or give context sensitive help if you don't hide the standard syntax)

If you do use a command beware adding extra white space (your definitions add several space tokens).

That said, \newcommand supports defining commands with an optional argument.

\newcommand{\fig}[3][\relax]{%
  \begin{figure}[htp]%
    \centering
      \includegraphics[#2]{#3}%
      \ifx\relax#1\else\caption{#1}\fi
  \end{figure}%
}

\fig{width = 0.50\textwidth}{fig/duck.pdf} % for fig without caption
\fig[Zzzzz]{width = 0.50\textwidth}{fig/duck.pdf} % for fig without caption

Answer 2

I don't think you gain too much with this approach. Anyway, here's a possible implementation.

\documentclass{article}
\usepackage{graphicx,xparse}

\ExplSyntaxOn
\NewDocumentCommand{\hfig}{O{}mO{}}
 {
  \group_begin:
  \keys_set:nn { hengxin/fig } { #3 }
  \use:x { \exp_not:N \begin{figure}[\l_hengxin_hfig_pos_tl] }
  \centering
  \includegraphics[#1]{#2}
  \tl_if_empty:NF \l_hengxin_hfig_caption_tl
   {
    \tl_if_empty:NTF \l_hengxin_hfig_shortcaption_tl
     {
      \caption{\l_hengxin_hfig_caption_tl}
     }
     {
      \caption[\l_hengxin_hfig_shortcaption_tl]{\l_hengxin_hfig_caption_tl}
     }
   }
  \end{figure}
  \group_end:
 }
\keys_define:nn { hengxin/fig }
 {
  caption .tl_set:N = \l_hengxin_hfig_caption_tl,
  shortcaption .tl_set:N = \l_hengxin_hfig_shortcaption_tl,
  pos .tl_set:N = \l_hengxin_hfig_pos_tl,
  pos .initial:n = htp,
 }
\ExplSyntaxOff

\begin{document}

\hfig[width=.3\textwidth]{example-image-a}

\hfig[width=.3\textwidth]{example-image-b}[
  caption=This is a caption\label{aaa},
  pos=bp
]

\end{document}

You can also specify a shortcaption key, for the case \caption[Short]{Long}.